Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change name, fix logic or provide correct description on failureButtonText #29

Open
RezMike opened this issue Nov 30, 2023 · 1 comment
Open

Change name, fix logic or provide correct description on failureButtonText #29

RezMike opened this issue Nov 30, 2023 · 1 comment

Comments

@RezMike
Copy link

RezMike commented Nov 30, 2023

Right now, on Android, failureButtonText is used for a button to cancel biometry dialog when fallback to backup notification method is not specified. It doesn't correspond to the text in mpp here and probably is not used the same way on iOS. The name creates misunderstanding, because it implies something like "Biometrics failure" text to be used for it, but actually on Android you should use just "Cancel"
@syed-hashir-ali
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RezMike @syed-hashir-ali