From cd083ae5ff6e0f6d7791a937f39a822b914f4e87 Mon Sep 17 00:00:00 2001 From: Borislav Stanimirov Date: Fri, 29 Dec 2023 14:58:23 +0200 Subject: [PATCH] gh ci: remove -j build flags as it's the default with ninja --- .github/workflows/unit-test.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index ba2324f..4396d11 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -15,19 +15,19 @@ jobs: matrix: cfg: # ubuntu sanitizing address, undefined, leak, thread - - {name: 'linux gcc dbg s:addr,ub,leak', os: ubuntu-latest, btype: Debug, cmakeflags: '-DSAN_ADDR=1 -DSAN_UB=1 -DSAN_LEAK=1', buildflags: '-- -j'} - - {name: 'linux gcc rel s:addr', os: ubuntu-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_ADDR=1', buildflags: '-- -j'} - - {name: 'linux gcc rel s:thread', os: ubuntu-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_THREAD=1', buildflags: '-- -j'} + - {name: 'linux gcc dbg s:addr,ub,leak', os: ubuntu-latest, btype: Debug, cmakeflags: '-DSAN_ADDR=1 -DSAN_UB=1 -DSAN_LEAK=1'} + - {name: 'linux gcc rel s:addr', os: ubuntu-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_ADDR=1'} + - {name: 'linux gcc rel s:thread', os: ubuntu-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_THREAD=1'} # macos - no ub santizer (there are still some apple-specific ub sanitizer issues to fix) # https://github.com/iboB/dynamix/issues/44 # also no leak sanitizer since it's not supported by apple - - {name: 'mac clang dbg s:addr', os: macos-latest, btype: Debug, cmakeflags: '-DSAN_ADDR=1', buildflags: '-- -j'} - - {name: 'mac clang rel s:addr', os: macos-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_ADDR=1', buildflags: '-- -j'} - - {name: 'mac clang rel s:thread', os: macos-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_THREAD=1', buildflags: '-- -j'} + - {name: 'mac clang dbg s:addr', os: macos-latest, btype: Debug, cmakeflags: '-DSAN_ADDR=1'} + - {name: 'mac clang rel s:addr', os: macos-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_ADDR=1'} + - {name: 'mac clang rel s:thread', os: macos-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_THREAD=1'} # windows: no santizer with RelWithDebInfo (likely a msvc sanitizer bug... working on it) # https://developercommunity.visualstudio.com/t/Address-sanitizer-in-Release-may-introdu/10314256?port=1025&fsid=c7b0f725-0959-4e2d-b63e-e4711eb92eca - - {name: 'win msvc dbg s:addr', os: windows-latest, btype: Debug, cmakeflags: '-DSAN_ADDR=1', buildflags: ''} - - {name: 'win msvc rel', os: windows-latest, btype: RelWithDebInfo, cmakeflags: '', buildflags: ''} + - {name: 'win msvc dbg s:addr', os: windows-latest, btype: Debug, cmakeflags: '-DSAN_ADDR=1'} + - {name: 'win msvc rel', os: windows-latest, btype: RelWithDebInfo, cmakeflags: ''} defaults: run: working-directory: ci @@ -48,7 +48,7 @@ jobs: - name: Configure run: cmake .. -G Ninja -DCMAKE_BUILD_TYPE=${{ matrix.cfg.btype }} ${{ matrix.cfg.cmakeflags }} - name: Build - run: cmake --build . ${{ matrix.cfg.buildflags }} + run: cmake --build . - name: Test run: ctest --output-on-failure env: