Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON not escaped correctly and multipart messages not handled #6

Open
Evidlo opened this issue Jan 15, 2025 · 0 comments
Open

JSON not escaped correctly and multipart messages not handled #6

Evidlo opened this issue Jan 15, 2025 · 0 comments

Comments

@Evidlo
Copy link

Evidlo commented Jan 15, 2025

Just two other issues I've found while using the application

  • Problem: JSON sent over MQTT is not escaped - if SMS content contains e.g. a double-quote, then the JSON sent is invalid

Fix: Use JSONObject to built MQTT payload

  • Problem: if the incoming SMS message is long (> 154 characters), it is split into multiple MQTT messages

Fix: Use getMessagesFromIntent to get all messages parts and then concatenate the string contents together

Evidlo/sms_llm@c7bb9fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant