Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script hack to set WITH_AFFINE variable with affine-extended removed #3

Open
gchabert opened this issue Dec 7, 2016 · 0 comments
Open
Assignees

Comments

@gchabert
Copy link

gchabert commented Dec 7, 2016

I am going to remove the following lines in the plugins/wscript:

if (conf.options.WITH_AFFINE_EXTEND): conf.options.WITH_AFFINE =True

because if the affine-extended plugin is not installed, these lines make the script crash.

I have tried to replace the test by something like
if 'WITH_AFFINE_EXTEND' in conf.option.keys()
but it does not work neither.

I really think that this kind of hack is ugly anyway and that there should be only one affine plugin with an additional option to let the user chose a specific implementation, like, e.g.:

waf configure --with-affine --affine-implementation=...

@gchabert gchabert transferred this issue from ibex-team/ibex-lib Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants