Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate provider instances at runtime #1384

Closed
mattiekat opened this issue Dec 5, 2022 · 3 comments
Closed

Deduplicate provider instances at runtime #1384

mattiekat opened this issue Dec 5, 2022 · 3 comments
Labels

Comments

@mattiekat
Copy link
Contributor

Currently every Mailbox, MailboxIndexer, InterchainGasPaymaster, InterchainGasPaymasterIndexer, ... (MakeableWithProvider) type creates a duplicate provider instance. This is fine at some levels since they are not maintaining connections, but for things like metrics, we make calls on intervals to update certain information which causes redundant queries.

Creating a way to deduplicate at least some levels of the stack will also allow for #1304 to be more useful.

@mattiekat mattiekat self-assigned this Dec 5, 2022
@jennifermarie jennifermarie moved this to On Deck in Hyperlane Tasks Dec 9, 2022
@jennifermarie jennifermarie moved this from On Deck to Sprint in Hyperlane Tasks Dec 27, 2022
@nambrot nambrot moved this from Sprint to On Deck in Hyperlane Tasks Jan 9, 2023
@nambrot
Copy link
Contributor

nambrot commented Jan 13, 2023

@mattiecnvr how critical is it to do this soon?

@nambrot nambrot added the agent label Jan 13, 2023
@nambrot nambrot moved this from On Deck to Backlog in Hyperlane Tasks Jan 13, 2023
@mattiekat
Copy link
Contributor Author

@mattiecnvr how critical is it to do this soon?

Not very. Definitely a nice to have change though.

@mattiekat mattiekat removed their assignment Oct 11, 2023
@nambrot
Copy link
Contributor

nambrot commented Feb 29, 2024

Close this in favor of #3321 if you agree @tkporter

@nambrot nambrot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 29, 2024
@github-project-automation github-project-automation bot moved this from icebox to Done in Hyperlane Tasks Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants