SSH Agent not supported for SFTP upload with make copied-site

[eskatos]

I tried using the support for SFTP upload with key authentication but ran into the following failure:

hydraulic.factory.builds.BuildSystemScheduler$TaskFailure: Task failed: Copied Site (copied-site)
        at hydraulic.factory.builds.BuildSystemScheduler$executeTask$$inlined$executeWithNamedThreadAndLogging$1.call(Unknown Source)
        ... 7 more
Caused by: hydraulic.shell.ShellLoginFailedException: Could not connect to ssh://[email protected]:22/mnt/volume-downloads/downloads/desktop: No more authentication methods available
        at hydraulic.shell.Shell$Companion.connectOverSSH(Unknown Source)
        at hydraulic.shell.Shell$Companion.at(Unknown Source)
        at hydraulic.shell.Shell$Companion.at$default(Unknown Source)
        at hydraulic.conveyor.tasks.CopiedSiteTask.uploadGeneric(Unknown Source)
        at hydraulic.conveyor.tasks.CopiedSiteTask.uploadSite(Unknown Source)
        at hydraulic.conveyor.tasks.CopiedSiteTask.build(Unknown Source)
        ... 8 more
Caused by: org.apache.sshd.common.SshException: No more authentication methods available
        at org.apache.sshd.client.session.ClientUserAuthService.tryNext(Unknown Source)
        at org.apache.sshd.client.session.ClientUserAuthService.processUserAuth(Unknown Source)
        at org.apache.sshd.client.session.ClientUserAuthService.process(Unknown Source)
        ...

We're exclusively using a SSH Agent both on developer machines and CI agents. As far as I could gather, Apache Mina, the library that Conveyor uses for SSH, doesn't support Agent-based authentication.

The workaround is to not use make copied-site but use make site and upload directly using scp.

I'm writing this here so that other people using the SSH Agent can identify what they are facing and find the workaround.

Having conveyor support SSH Agent authentication would make integrating it easier but given there's a workaround I understand that this would not get prioritized especially because the underlying SSH library lacks support for it.

[mikehearn]

Mina has other problems too. It's convenient, but when 'scp' is available it might make more sense to shell out and use it if there's a way to do that nicely. I think Windows has it installed by default these days also.