Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage with gatsby-plugin-next-seo? #55

Open
jakubjafra opened this issue Jan 25, 2021 · 0 comments
Open

Usage with gatsby-plugin-next-seo? #55

jakubjafra opened this issue Jan 25, 2021 · 0 comments

Comments

@jakubjafra
Copy link

Hi! :)

There is a neat new package called gatsby-plugin-next-seo with uses react-helmet-async instead of react-helmet. This plugin, however, requires you to use react-helmet. Is there a way to lift that requirement? I'd like to use any helmet lib.

Right now, when using both react-helmet's there are errors, like - for example - <title> is rendered empty.

I tried switching to react-helmet-async by overwriting gatsby-theme-material-ui-top-layout/components/viewport.js and replacing react-helmet with react-helmet-async but in the gatsby-node.js the gatsby-plugin-react-helmet is still required. I ultimately resolved this issue by using patch-package and removing those entries locally.

I could post a pull request with a change, but I'm unsure what's the best way to proceed.

Thanks

@jakubjafra jakubjafra changed the title Usage with gatsby-plugin-next-seo Usage with gatsby-plugin-next-seo? Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant