Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ruff native formatter #186

Closed
dacorvo opened this issue Apr 22, 2024 · 12 comments
Closed

Switch to ruff native formatter #186

dacorvo opened this issue Apr 22, 2024 · 12 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dacorvo
Copy link
Collaborator

dacorvo commented Apr 22, 2024

Ruff is faster than black and produces nearly identical results.

The goal of this issue is to switch to ruff for the style check and formatting.

@dacorvo dacorvo added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 22, 2024
@dacorvo dacorvo mentioned this issue Apr 22, 2024
4 tasks
@aryanmagoon
Copy link

By switching to ruff for style check and formatting, do you mean removing black? It looks like both black and ruff run to do style check in workflows and as in the instructions for contributing, running make style formats with both packages.

@dacorvo
Copy link
Collaborator Author

dacorvo commented Apr 29, 2024

Yes, it means removing black and use only ruff.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 30, 2024
@dacorvo dacorvo removed the Stale label May 30, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 30, 2024
@dacorvo dacorvo removed the Stale label Jul 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 1, 2024
Copy link

github-actions bot commented Aug 7, 2024

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
@davidgao7
Copy link

Yes, it means removing black and use only ruff.

Dear optimum-quanto maintainers, I saw black is still in the setup.sh and pyproject.toml, are we still considering switching?

@dacorvo dacorvo removed the Stale label Aug 26, 2024
@dacorvo
Copy link
Collaborator Author

dacorvo commented Aug 26, 2024

Yes, it means removing black and use only ruff.

Dear optimum-quanto maintainers, I saw black is still in the setup.sh and pyproject.toml, are we still considering switching?

Yes, this is still planned, but no pull-request has been submitted yet.

@dacorvo dacorvo reopened this Aug 26, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@ishandeva
Copy link
Contributor

@dacorvo Submitted a pull request for this, please review and let me know.
Thanks.

Copy link

github-actions bot commented Nov 6, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 6, 2024
@dacorvo
Copy link
Collaborator Author

dacorvo commented Nov 10, 2024

Done in #334

@dacorvo dacorvo closed this as completed Nov 10, 2024
@dacorvo dacorvo removed the Stale label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants