Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Door NFRC values #280

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Door NFRC values #280

wants to merge 2 commits into from

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Jul 13, 2021 •
edited
Loading

Closes #279.

  1. Adds UFactor and SHGC elements for doors.
  2. Adds DoorDescription element. Choices based on NFRC are: "embossed", "flush", "full lite", "1/2 - lite", "1/4 - lite", "3/4 - lite", "raised panel", and "other".
  3. Clarifies that UFactor/RValue elements (for doors, windows, and skylights) include air films.

Should we mark RValue as deprecated, so that UFactor is used instead going forward?

@shorowit shorowit self-assigned this Jul 13, 2021
@shorowit
Copy link
Contributor Author

shorowit commented Jul 21, 2021 •
edited
Loading

Copy over other elements like Overhangs (or use WindowInfo group of elements).
Note that the WindowType proposal allows a door choice.
Some support for marking RValue as deprecated.

@shorowit
Copy link
Contributor Author

It would be hard to further improve this without making breaking changes. I suggest we defer this until v4.0 and do this correctly.

@shorowit shorowit added this to the v4.0 milestone Jul 21, 2021
@shorowit shorowit marked this pull request as draft July 21, 2021 17:31
@nmerket
Copy link
Contributor

nmerket commented Jul 26, 2021

Discussion in 7/21/2021 Working Group Meeting

@shorowit shorowit removed this from the v4.0 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@12Thee 12Thee 12Thee approved these changes

Assignees

@shorowit shorowit

Labels
enhancement schemas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow NFRC values for doors
3 participants
@shorowit @nmerket @12Thee