From 91da9f446719196a4709b9942901293e5f3622ac Mon Sep 17 00:00:00 2001 From: Fabio Niephaus Date: Tue, 7 Jan 2025 15:56:01 +0100 Subject: [PATCH] Revert "Ignore compilation errors temporarily" This reverts commit 86b417e940a82748dc089379ae5c2e46c49dc999. --- .github/workflows/ci.yml | 3 +-- mx.trufflesqueak/mx_trufflesqueak.py | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cdf62e1ea..74dd97afd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -218,7 +218,6 @@ jobs: - name: Run Cuis-Smalltalk tests on TruffleSqueak standalone run: | mx.trufflesqueak/utils.sh download-cuis-test-image - trufflesqueak --vm.ea --vm.esa --headless --experimental-options --smalltalk.resource-summary=true --engine.CompilationFailureAction=Silent --engine.CompilationStatistics images/Cuis6.0-????.image -s src/de.hpi.swa.trufflesqueak.test/src/de/hpi/swa/trufflesqueak/test/runCuisTests.st - # trufflesqueak --vm.ea --vm.esa --headless --experimental-options --smalltalk.resource-summary=true --compiler.TreatPerformanceWarningsAsErrors=call,instanceof,store,trivial --engine.CompilationFailureAction=ExitVM --engine.CompilationStatistics images/Cuis6.0-????.image -s src/de.hpi.swa.trufflesqueak.test/src/de/hpi/swa/trufflesqueak/test/runCuisTests.st + trufflesqueak --vm.ea --vm.esa --headless --experimental-options --smalltalk.resource-summary=true --compiler.TreatPerformanceWarningsAsErrors=call,instanceof,store,trivial --engine.CompilationFailureAction=ExitVM --engine.CompilationStatistics images/Cuis6.0-????.image -s src/de.hpi.swa.trufflesqueak.test/src/de/hpi/swa/trufflesqueak/test/runCuisTests.st timeout-minutes: 10 if: ${{ matrix.os == 'ubuntu-20.04' }} diff --git a/mx.trufflesqueak/mx_trufflesqueak.py b/mx.trufflesqueak/mx_trufflesqueak.py index ec31def0e..d9fb5fd6c 100644 --- a/mx.trufflesqueak/mx_trufflesqueak.py +++ b/mx.trufflesqueak/mx_trufflesqueak.py @@ -84,9 +84,9 @@ def _add_unit_tests(tasks, supports_coverage): if _COMPILER: unittest_args.extend( [ - "-Dgraal.CompilationFailureAction=Silent", - # "-Dpolyglot.compiler.TreatPerformanceWarningsAsErrors=call,instanceof,store,trivial", - "-Dpolyglot.engine.CompilationFailureAction=Silent", + "-Dgraal.CompilationFailureAction=ExitVM", + "-Dpolyglot.compiler.TreatPerformanceWarningsAsErrors=call,instanceof,store,trivial", + "-Dpolyglot.engine.CompilationFailureAction=ExitVM", "-Dpolyglot.engine.CompilationStatistics=true", ] )