BC-8737 - Add missing tests (and more) for video conference feature #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
odalys-dataport
requested changes
Jan 22, 2025
...ature/board-video-conference-element/components/VideoConferenceContentElementDisplay.unit.ts
Outdated
Show resolved
Hide resolved
...ature/board-video-conference-element/components/VideoConferenceContentElementDisplay.unit.ts
Outdated
Show resolved
Hide resolved
...ules/feature/board-video-conference-element/components/VideoConferenceContentElement.unit.ts
Outdated
Show resolved
Hide resolved
...ules/feature/board-video-conference-element/components/VideoConferenceContentElement.unit.ts
Show resolved
Hide resolved
...ules/feature/board-video-conference-element/components/VideoConferenceContentElement.unit.ts
Show resolved
Hide resolved
odalys-dataport
previously approved these changes
Jan 22, 2025
uidp
reviewed
Jan 22, 2025
|
|
||
| const emit = defineEmits(["click", "refresh"]); | ||
|
|
||
| const imageSrc = image; | ||
|
|
||
| const props = defineProps({ | ||
| boardParentType: { | ||
| type: Object as PropType<BoardContextType | undefined>, | ||
| required: true, |
There was a problem hiding this comment.
How can this be required if it can be undefined?
…into BC-8737-missing-stuff
|
odalys-dataport
approved these changes
Jan 23, 2025
uidp
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Adding remaining unit tests for FE part of Video Conference Feature.
Also smaller fixes (e.g. correcting note texts) is included.
Links to Ticket and related Pull-Requests
BC-8737
hpi-schul-cloud/schulcloud-server#5445
Changes
Screenshots of UI changes
Checklist before merging