Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #5

Open
courajs opened this issue Jul 13, 2016 · 3 comments
Open

Add tests #5

courajs opened this issue Jul 13, 2016 · 3 comments

Comments

@courajs
Copy link
Contributor

courajs commented Jul 13, 2016

Let's add some acceptance tests to make sure bindings update automatically

  • sign in/sign out
  • adding records
  • updating records
  • etc
@gr2m
Copy link
Member

gr2m commented Jul 13, 2016

I’ll try to create a dummy app and acceptance tests

@gr2m gr2m self-assigned this Jul 13, 2016
@gr2m gr2m mentioned this issue Jul 13, 2016
@courajs
Copy link
Contributor Author

courajs commented Aug 13, 2016

A few issues have popped up while trying to add tests, mostly around persistent state.
For example, testing user sign up can only run once right now, breaking ember test --server.
We can add a teardown to destroy the account. Or check during setup for existence of the account and destroy it there.
It's also sometimes the case that localStorage contains an invalid auth token from a previous run, and that needs to be cleared.
It feels like we need some sort of "wipe hoodie" action we could do before each test.

@gr2m
Copy link
Member

gr2m commented Aug 14, 2016

It feels like we need some sort of "wipe hoodie" action we could do before each test.

I’ll look into it! For the time being, localStorage.clear() and page reload should do the trick, can you give it a try? I’m traveling right now, but will be back to work Monday afternoon

@gr2m gr2m removed their assignment Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants