NoMethodError when removing a step from a campaign

[rathboma]

I removed a step from a campaign, but now I get the following error in the background cron job:

NoMethodError: undefined method `action' for nil:NilClass

It's happening at this line:

heya//lib/heya/campaigns/step_action_job.rb

Line 11 in f472417

step.action.new(user: user, step: step).deliver_now

      def perform(_campaign, user, step)
        step.action.new(user: user, step: step).deliver_now
      end

step is nil, so this fails.

[joshuap]

@rathboma thanks for reporting. Do you think there were some active jobs for that step when the change that removed it was deployed? We should probably add a guard for that. 🤔

[joshuap]

FYI, I've started on this but I'm still deciding the best way to handle it.

[rathboma]

Yes, there could have been some active jobs that were not picked up properly after the restart.