Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation instructions are missing a step #2

Open
engstrom opened this issue Jan 4, 2014 · 7 comments
Open

Installation instructions are missing a step #2

engstrom opened this issue Jan 4, 2014 · 7 comments

Comments

@engstrom
Copy link

engstrom commented Jan 4, 2014

To install the extension in Chrome I had to move the js files into the Chrome folder since all of the paths in the manifest file are relative.

@honestbleeps
Copy link
Owner

You're supposed to run the make links script actually.
On Jan 3, 2014 9:36 PM, "Dustin Engstrom" [email protected] wrote:

To install the extension in Chrome I had to move the js files into the
Chrome folder since all of the paths in the manifest file are relative.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2
.

@engstrom
Copy link
Author

engstrom commented Jan 4, 2014

My bad. I skipped straight to the "Instructions for loading/testing" section and missed that.

@wormeyman
Copy link
Contributor

I ran the make links script and I think the /lib/modules folder needs to be added to it?

@honestbleeps
Copy link
Owner

makelinks.sh should hardlink all files from lib/* and lib/modules/* to each browser's directory -- note that there's an update to makelinks.sh i made recently because of the new split... I copied it over from RES, though, so it's possible it needs an edit or two, I'll try and test later!

@wormeyman
Copy link
Contributor

I used the bat file since i am on windows, i'll take a look at the sh and see if i can understand it.

@honestbleeps
Copy link
Owner

ahh, sorry, I haven't updated the bat file yet -- you're right, those files need to be added... or ideally I should re-jog my memory on doing more worthwhile things with BAT files (I'm sure I can replicate the way makelinks.sh works)... I just haven't had time.. my apologies for the confusion!

@wormeyman
Copy link
Contributor

Take a look at my pull request for the bat, Just be aware that i have not tested it on anything but chrome. Also on the bat file what is the files=() for at the top?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants