We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First off, thank you for all your hard work.
Line 687 of https://github.com/homebridge/HAP-NodeJS/blob/latest/src/lib/datastream/DataStreamParser.ts should be
} else if (number >= -2147483648 && number <= 2147483648) {
instead of
} else if (number >= -2147483648 && number <= -2147483648) {
The difference is the negative sign infront of the upper bound check.
Cheers.
The text was updated successfully, but these errors were encountered:
Now that I think about it some more, it should probably be
} else if (number >= -2147483648 && number <= 2147483647) {
to reflect the range of a signed int 32.
Sorry, something went wrong.
No branches or pull requests
First off, thank you for all your hard work.
Line 687 of https://github.com/homebridge/HAP-NodeJS/blob/latest/src/lib/datastream/DataStreamParser.ts should be
} else if (number >= -2147483648 && number <= 2147483648) {
instead of
} else if (number >= -2147483648 && number <= -2147483648) {
The difference is the negative sign infront of the upper bound check.
Cheers.
The text was updated successfully, but these errors were encountered: