Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN] Can't set brightness of lights in a zone without specifying the light name #2763

Open
Sleuth56 opened this issue Dec 20, 2024 · 4 comments · May be fixed by #2783
Open

[EN] Can't set brightness of lights in a zone without specifying the light name #2763

Sleuth56 opened this issue Dec 20, 2024 · 4 comments · May be fixed by #2783
Assignees
Labels

Comments

@Sleuth56
Copy link

Steps to reproduce:

  1. Setup voice pipline
  2. Add a smart light to a zone
  3. Add a voice device to HA and set it to the same zone as the light
  4. Say to the voice device Set the lights to 50%

Screenshot_20241219-180318

I did notice in my testing that Set the brightness to 50% works.
Screenshot_20241219-180927

@tetele tetele self-assigned this Dec 20, 2024
@tetele tetele changed the title Can't set brightness of lights in a zone without specifying the light name [EN] Can't set brightness of lights in a zone without specifying the light name Dec 20, 2024
@mitrokun
Copy link
Contributor

There was a similar question in this issue
This feature is easy to implement, but is it worth it?

@ViViDboarder
Copy link
Contributor

Should be covered by #2783

@tetele
Copy link
Contributor

tetele commented Jan 3, 2025

This feature is easy to implement, but is it worth it?

Yes, it is. I can imagine sitting in a room with dimmable lights, asking for the lights to be set to X% brightness. Of course i mean just that room.

@tetele tetele linked a pull request Jan 3, 2025 that will close this issue
@mitrokun
Copy link
Contributor

mitrokun commented Jan 3, 2025

I can imagine sitting in a room with dimmable lights

It should be clarified that this function was added for the English language almost a year ago (in your PR😀) . The problem discussed in this issue is related to the lack of a short version of the phrase.

But as for my opinion, I do not think that the current implementation of this intent works well for everyone.
If you have a large variety of lighting fixtures in the room, then running this command will lead to chaos.
Also short version of phrases may be misidentified if local tiny/small stt models are used.

A solution could be to add to the HA the functionality of dividing the light in the room into main and auxiliary.
Then the phrase "Set lights to 50%" would only affect the main light, and "Set all lights to 50%" would affect all devices in the room. Auxiliary lights are controlled by name.
In this case, false alarms would not be so critical, and the convenience of controlling lighting devices would increase.
Now this problem is solved by creating additional areas or using labels and own intent_script

The same questions apply to the light_HassTurnOn intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants