Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs should fail if they leave the repo dirty #8

Open
maximlt opened this issue Nov 29, 2022 · 0 comments
Open

Jobs should fail if they leave the repo dirty #8

maximlt opened this issue Nov 29, 2022 · 0 comments

Comments

@maximlt
Copy link
Contributor

maximlt commented Nov 29, 2022

I think a job should fail if it lets the repo in a dirty state after it has done its work. That would be done adding an additional step at the end of the job, or before the deployment step if it has one. Maybe something like:

git diff --quiet || exit 1

This is important to ensure that when developers run the tests, build the site or the packages, they don't end up with undesired files.

@maximlt maximlt added this to Infra Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant