Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World fails to generate with GregTech installed #11

Closed
MCTian-mi opened this issue Dec 27, 2024 · 8 comments
Closed

World fails to generate with GregTech installed #11

MCTian-mi opened this issue Dec 27, 2024 · 8 comments
Assignees
Labels
crash Game crash case

Comments

@MCTian-mi
Copy link

Modpack

World customization preset
N/A

World seed
N/A

Teleport command to problematic coordinates
N/A

Crash-report file
latest.log
debug.log

Steps to reproduce the crash

  1. Install above mentioned mods
  2. Try to generate a world
  3. Game freezes
  4. Cry helplessly

Note: randomly the world managed to generate, if you're lucky enough. But mostly it fails to do so.
I also tried adding gregtech to some of the options in the config but that didn't help.

@MCTian-mi MCTian-mi added the crash Game crash case label Dec 27, 2024
@MCTian-mi
Copy link
Author

ah well this is technically not a crash
sorry for that

@hohserg1
Copy link
Owner

hohserg1 commented Jan 7, 2025

huh, logs kinda doesnt contains any clue
is GregTech compatible with pure CC?
and plz, paste World customization preset and World seed, I need it to reproduce bug

@MCTian-mi
Copy link
Author

this seems to be an issue between cc & gregtech
using a custom cc build merging OpenCubicChunks/CubicChunks#775 allows the stacktrace to be printed normally
this is an issue on gregtechceu side
this code def isn't written with dynamic world height in mind

@MCTian-mi
Copy link
Author

MCTian-mi commented Jan 7, 2025

huh, logs kinda doesnt contains any clue is GregTech compatible with pure CC? and plz, paste World customization preset and World seed, I need it to reproduce bug

ah sorry I thought it wasn't seed or preset related
anyways closing this

@MCTian-mi
Copy link
Author

MCTian-mi commented Jan 7, 2025

I did try running gregtech with cc itself but that worked when I tried it
probably because of no rubber tree was generated in that seed
turns out I'm wrong on this

@hohserg1
Copy link
Owner

hohserg1 commented Jan 7, 2025

ok, its looks like, GT attempts to place tree at top of world and have custom loop logic of finding top
I see it should be too long loop at vanilla CC, but kinda it should work fine with DL bc DL using fake world with only 255 world height, so its strange

@MCTian-mi
Copy link
Author

I tried disabling rubber tree generation in gregtech.cfg, or using a custom gregtech build with the generation code changed to use height map:

- pos.setPos(pos.getX() + 8, world.getHeight() - 1, pos.getZ() + 8);
+ pos.setPos(pos.getX() + 8, world.getHeight(pos.getX() + 8, pos.getZ() + 8), pos.getZ() + 8);

in both cases it worked fine with DL

@hohserg1
Copy link
Owner

hohserg1 commented Jan 7, 2025

ok, I see, DL have correct impl of getHeight(x,z), but wrong impl of getHeight()
I can improve it, so thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Game crash case
Projects
None yet
Development

No branches or pull requests

2 participants