Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issue in 2.0-develop - (JSON parser) #39

Open
hoche opened this issue Jun 20, 2023 · 1 comment
Open

Build issue in 2.0-develop - (JSON parser) #39

hoche opened this issue Jun 20, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@hoche
Copy link
Owner

hoche commented Jun 20, 2023

2.0-alpha doesn't build - it looks like there's a commandline parsing routine that was expected to set the "args" variable, but it got commented out. If that parser isn't stable we should leave it and everything that depends on it out.

~/src/splat/build$ make
[  2%] Building CXX object src/CMakeFiles/splat.dir/main.cpp.o
/home/hoche/src/splat/src/main.cpp: In function ‘int main(int, const char**)’:
/home/hoche/src/splat/src/main.cpp:1204:24: error: ‘args’ was not declared in this scope; did you mean ‘argc’?
 1204 |         json.WriteJSON(args, tx_site[0], lrp, mapfile);
      |                        ^~~~
      |                        argc
make[2]: *** [src/CMakeFiles/splat.dir/build.make:225: src/CMakeFiles/splat.dir/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:216: src/CMakeFiles/splat.dir/all] Error 2
make: *** [Makefile:149: all] Error 2
@hoche hoche added the bug Something isn't working label Jun 20, 2023
@hoche hoche added this to the 2.0 milestone Jun 20, 2023
@hoche
Copy link
Owner Author

hoche commented Jun 21, 2023

I renamed some branches, so I changed the topic. I have disabled the parsing in 2.0.0b1 and 2.0-develop.

@hoche hoche changed the title Build issue in 2.0-alpha - (JSON parser) Build issue in 2.0-develop - (JSON parser) Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants