Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session device info can be manipulated #55

Open
made-by-traxam opened this issue Oct 22, 2021 · 0 comments
Open

session device info can be manipulated #55

made-by-traxam opened this issue Oct 22, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@made-by-traxam
Copy link
Collaborator

There are multiple issues with the way the deviceInfo property is filled in the POST /login route:

  1. the IP hash is generated using generateToken(ip) but generateToken is not a hash function since it involves random data
  2. the deviceInfo property in the request body is not validated and can contain arbitrary data which is inserted straight into our database. Users can, for example, manipulate the effective value of ipHash. Also, the deviceInfo content is not useful if we do not enforce a specific structure.
@made-by-traxam made-by-traxam added the bug Something isn't working label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@made-by-traxam