Additional redis options

[fabianboeller]

Hi all!

While setting up redisdown with Nx I discovered that some options are not passed on to node-redis.
The options look to be restricted to these options: https://github.com/hmalphettes/redisdown/blob/master/index.js#L264
For the connection to a password-protected cache, we also need the tls and password option.
Is it safe/correct to add these options or maybe even to remove the filtering altogether such that all options are passed on to node-redis?

[seigel]

Great questions. I will have to take a look and try to understand what the original author had in mind with those restrictions and then see what it would take to pass at least the ones that you are interested in, on. If you have ideas, please add a patch file or a PR with some tests to expedite the investigation. Thanks!

[seigel]

I see what you are seeing. It looks as if the original author overloaded the meaning of _makeRedisId with option cleansing as well. _makeRedisId is used to cache the connections, which is valid to use a subset. I will see if there is some reason to NOT pass on other options as necessary to make the client connection to Redis.

[seigel]

I don't see a reason why not to..so please go ahead and use it that way. I am working on getting the correct changes in and updating some testing.