Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show indentation or comas in diff #24

Open
erdnaxeli opened this issue Mar 30, 2022 · 3 comments
Open

Don't show indentation or comas in diff #24

erdnaxeli opened this issue Mar 30, 2022 · 3 comments

Comments

@erdnaxeli
Copy link

The diff shows indent and coma diff, which useless.

image
image

@hjwp
Copy link
Owner

hjwp commented Apr 23, 2022

just to make sure we're on the same page, you'd like to remove non-semantically relevant parts from diffs, is that right?

you're not saying that the test reported an assert equals failure on two objects that are actually the same? that would be very surprising.

i guess one solution would be to try and canonicalise the left and right hand sides. can you think of a way of doing that?

@erdnaxeli
Copy link
Author

just to make sure we're on the same page, you'd like to remove non-semantically relevant parts from diffs, is that right?

yes, that's it. It does not make the test fail, but if the test fails those diff are reported.

@hjwp
Copy link
Owner

hjwp commented Jul 6, 2022

gotcha. well i guess you'd need a way to "canonicalize" the whitespace and commas on both sides -- can you think of a way of doing that?

i guess you could do it manually in your tests, before the assert?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants