Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure deployed files were pushed to remote before deploy. #2

Open
ovenum opened this issue Oct 30, 2024 · 2 comments
Open

Ensure deployed files were pushed to remote before deploy. #2

ovenum opened this issue Oct 30, 2024 · 2 comments

Comments

@ovenum
Copy link

ovenum commented Oct 30, 2024

Hi Rasso! Thanks for this Tool!

Before uploading the files from a local folder, checking that there are no unpushed changes in the current working directory would be nice to have.

This can prevent some accidental mistakes where uncomitted files are deployed to the server via rsync.

@hirasso
Copy link
Owner

hirasso commented Oct 30, 2024

Great idea! I think it would make sense to still allow deployment with an unclean working dir. But asking "Are you sure?" would be nice.

Aside from that, checking if the latest local commit matches the latest remote commit (if there is a remote) could also proof handy.

@ovenum
Copy link
Author

ovenum commented Oct 30, 2024

Great idea! I think it would make sense to still allow deployment with an unclean working dir. But asking "Are you sure?" would be nice.

Personally I would prefer separate action for doing this. It's a more conscious decision then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants