-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactions state management with react query #4244
Comments
Looks like this is set to in progress but has no point estimate? @kurtisassad |
Did some work and apart from the reaction thread controller we have some API calls of reactions endpoints in the threads and some controllers. These are all the files that have some /reactions related API calls what I am concerned about is threads.ts. Should we move the reaction-related API calls from |
@mzparacha feel free to move the reactions functions around as needed -- if it makes sense to move them from threads.ts, then that's fine (see the old TODO anyway!). |
This is under review and should be mergeable once @masvelio marks his comments as resolved. |
Description
Follow-up for #4186. We should use react-query to store + mutate the state of reactions, rather than relying on raw HTTP requests + event emitters. See client/scripts/state/api/topics as a reference.
Engineering Requirements
Acceptance Criteria
No product-facing changes or regressions.
The text was updated successfully, but these errors were encountered: