Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wget from L105 of the action to be universal. #57

Open
Virus5600 opened this issue Dec 30, 2024 · 2 comments
Open

Update wget from L105 of the action to be universal. #57

Virus5600 opened this issue Dec 30, 2024 · 2 comments

Comments

@Virus5600
Copy link

Virus5600 commented Dec 30, 2024

I'm testing on both Ubuntu and Windows for my actions but it kept failing at Lines 102 - 107 due to wget only available when the OS is set to Ubuntu.

image

A quick fix of having a conditional step for this or using suisei-cn/actions-download-file workflow can be applied to prevent such errors.

This line would suffice for the latter option:

    - name: Download fabric-api v${{ inputs.fabric-api }}
      uses: suisei-cn/actions-download-file@818d6b7dc8fe73f2f924b6241f2b1134ca1377d9
      with:
        url: https://maven.fabricmc.net/net/fabricmc/fabric-api/fabric-api/${{ inputs.fabric-api }}+${{ inputs.mc }}/fabric-api-${{ inputs.fabric-api }}+${{ inputs.mc }}.jar
        target: "run/mods"
@ChipWolf
Copy link
Member

ChipWolf commented Dec 31, 2024

@Virus5600 any specific reason you're running the action on a Windows runner?
I'm willing to work toward officially supporting Windows runners if there's a genuine use-case.

I would be entirely opposed to using that action you mentioned though, it seems to be wildly overcomplicated for fetching a single file.

I'm also relatively sure curl in some form is in GitHub's Windows runner images and I'm keen to avoid another dependency if possible.

@ChipWolf
Copy link
Member

I just checked, curl is available on the Windows runners @Virus5600
I'll accept a PR if you'd like to go that direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants