Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically populate regex and java inputs #29

Open
ChipWolf opened this issue Dec 5, 2024 · 0 comments
Open

Dynamically populate regex and java inputs #29

ChipWolf opened this issue Dec 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ChipWolf
Copy link
Member

ChipWolf commented Dec 5, 2024

Right now, using the action requires a regex input to targer the file that gets downloaded by:

java -jar headlessmc-launcher-${{ inputs.hmc-version }}.jar --command ${{ inputs.modloader }} ${{ inputs.mc }} --java ${{ inputs.java }}

This feels a bit clunky and could be simplified for better UX. Here are a couple of ideas:

  • Make headlessmc-launcher more machine-friendly:

    It could output something like JSON or write a file with the info about the downloaded file (e.g., a manifest).

  • Smarter file detection in the action itself:

    The action could scan the directory for new files to figure out what’s been downloaded.


We also require users to run the setup-java action first, which means the runner already knows which version of Java is set up. Instead of requiring users to explicitly pass the java input, we could dynamically detect the version from the environment. Further simplifying use of the action.


In both instances, there will be edge cases, so we should keep the inputs available as optionals.

@ChipWolf ChipWolf changed the title Dynamically populate regex input Dynamically populate regex and java inputs Dec 5, 2024
@ChipWolf ChipWolf added the enhancement New feature or request label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant