Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: entry point functions parameter is required #215

Open
gillyspy opened this issue Aug 24, 2022 · 0 comments
Open

bug: entry point functions parameter is required #215

gillyspy opened this issue Aug 24, 2022 · 0 comments

Comments

@gillyspy
Copy link

gillyspy commented Aug 24, 2022

I use eslint (typescritp-eslint) and specifically some rules like:

no-unused-vars
an ban-ts-comment

I would argue that types such as EntryPoints.Client.fieldChanged should be defined as:

type fieldChanged = (scriptContext?: fieldChangedContext) => void;

and that perhaps even:

 interface fieldChangedContext {
            currentRecord: N_record.ClientCurrentRecord;
            sublistId: string;
            fieldId: string;
            line: number;
            column: number;
        }

        
        type fieldChanged = (scriptContext?: fieldChangedContext) => void;

could be:

 interface fieldChangedContext {
            currentRecord?: N_record.ClientCurrentRecord;
            sublistId?: string;
            fieldId?: string;
            line?: number;
            column?: number;
        }
       
        type fieldChanged = (scriptContext?: fieldChangedContext) => void;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant