Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow for large parts #5

Open
ianxm opened this issue Jun 3, 2023 · 1 comment
Open

Slow for large parts #5

ianxm opened this issue Jun 3, 2023 · 1 comment
Assignees

Comments

@ianxm
Copy link

ianxm commented Jun 3, 2023

For large parts (over 10k) this slows down. I extended the ParserTest to 20k and the TinkParser test takes over 10 seconds. My machine is old but 10 seconds is a lot. This is using hashlink. Is this expected? Is it meant to be done differently for larger payloads?

@back2dos
Copy link
Member

back2dos commented Jun 5, 2023

Well, tink libs run the risk of performing poorly on HL, because HL's GC is for example not generational, and tink assumes that short lived objects are cheap (as they are on most targets). But this definitely seems excessive.

I must admit, I've only build prod servers with node and php, where for the former one would use BusboyParser and for the latter it's handled by php. So I can't really say how good the TinkParser is. Still 10s for a 20k chunk should be easy to improve upon ^^

@back2dos back2dos self-assigned this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants