Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the stm-containers based DiagnosticStore from HLS #553

Open
michaelpj opened this issue Feb 5, 2024 · 0 comments
Open

Port the stm-containers based DiagnosticStore from HLS #553

michaelpj opened this issue Feb 5, 2024 · 0 comments
Labels
good first issue v3 Next really big release ZuriHac

Comments

@michaelpj
Copy link
Collaborator

HLS has its own implementation of DiagnosticStore that uses the STM map from stm-containers. This is a good idea, not sure why we didn't just upstream it at the time.

https://github.com/haskell/haskell-language-server/blob/b91c9076367123e983087ed305d183288a23f494/ghcide/src/Development/IDE/Core/Shake.hs#L1306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue v3 Next really big release ZuriHac
Projects
HLS & Friends Zurihac
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelpj