Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] readline's completion-ignore-case #84

Open
wizzup opened this issue Jun 18, 2018 · 6 comments
Open

[Feature request] readline's completion-ignore-case #84

wizzup opened this issue Jun 18, 2018 · 6 comments

Comments

@wizzup
Copy link

wizzup commented Jun 18, 2018

It would be nice if completion can be case-insensitive. Different behavior in bash prompt and ghci prompt drive me crazy.

@ibispi
Copy link

ibispi commented Aug 30, 2018

A friend of mine (who doesn't have a github account) has sent you
a patch (via email) dealing with this. Did you receive it?

@wizzup
Copy link
Author

wizzup commented Aug 31, 2018

I can't find any. Can you fork the repo and open the pull request so everyone can take a look?

Also this might related to PR #7

@ibispi
Copy link

ibispi commented Aug 31, 2018

My friend says:
(mail sent). In case anyone wants to check the patch, here it is http://paste.debian.net/plainh/ec5ae904

wizzup added a commit to wizzup/haskeline that referenced this issue Sep 1, 2018
@wizzup
Copy link
Author

wizzup commented Sep 1, 2018

Thanks, I just put the patch on. I will see if I can make my ghci use this patched haskline.

I will not create a PR because I am not patch's author.

@judah
Copy link
Collaborator

judah commented Sep 3, 2018

The title of this PR mentions completion-ignore-case, which would be equivalent to having a new user preference in ~/.haskeline. In contrast, the patch @wizzup linked would be more about enabling individual applications to choose to implement it themselves.

It seems the former might be a better option (or at least more general) and would more directly resolve the corresponding GHC ticket (https://ghc.haskell.org/trac/ghc/ticket/15452). However, I'm not sure yet whether it's feasible the way Haskeline's API is currently set up. I'll aim to take a closer look at the code in the next few days.

@wizzup
Copy link
Author

wizzup commented Sep 4, 2018

to having a new user preference in ~/.haskeline

That what I really want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants