Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using official golang/net #45

Closed
wants to merge 1 commit into from
Closed

using official golang/net #45

wants to merge 1 commit into from

Conversation

zabawaba99
Copy link

fixes #44

@rasky
Copy link

rasky commented Sep 6, 2015

Can we get this patch merged? It fixes Go 1.5 support, and it's just one click for you.

@armon
Copy link
Member

armon commented Sep 6, 2015

We need to rebase our fork of the package. That upstream does not promise stability and has broken our build many times, hence the private fork.

@zabawaba99
Copy link
Author

Is this something that you'd like to do @armon or would you like me to open a PR into the fork?

@cryptix
Copy link

cryptix commented Oct 26, 2015

See #37

@zabawaba99 zabawaba99 closed this May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't go get with Go 1.5
4 participants
@zabawaba99 @rasky @armon @cryptix