Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App gestures: Rethink animation for reverse gestures #186

Open
tradeJmark opened this issue Jun 2, 2023 · 2 comments
Open

App gestures: Rethink animation for reverse gestures #186

tradeJmark opened this issue Jun 2, 2023 · 2 comments

Comments

@tradeJmark
Copy link

Hi there.
Firstly, huge thanks for even making this work at all, because not being able to do it on Gnome has been driving me crazy for years. It does seem like there are a few issues (or, two issues and a nitpick) with the implementation right now though that I don't see mentioned elsewhere, so I wanted to bring them up and see if anyone else has run into them.

My system is Ubuntu 22.03, Chrome 112.0.5615.165, Firefox 113.0.

  • Maybe this is subjective and more to do with my particular experience (although it's mostly been vanilla stuff, various versions of Windows and MacOS), but I've never before encountered this swipe right for back, left for forward thing. I know you can change it if you want, but I really feel the default should be left/back and right/forward, that's how everything else I've ever used works. That's less a bug though and more debatable, maybe I'm the weird one.
  • In Chrome, if the gesture is set to be reversed, the animations stay the same and thus are incorrect with respect to the actual action being performed. Actually, my preference would be to just have an option to turn off the animation, it doesn't do much for me.
  • In Firefox, setting the gesture to be reversed has no effect.

If anyone does have time to look into this, then, massive thank you!

@klknn
Copy link

klknn commented Jun 5, 2023

In my enviroment Ubuntu 22.04 + Firefox 113.0, the forward/backward with reverse gesture direction mode is working but arrows on UI are unchanged (i.e. UI shows opposite directions when the gesture is reversed).

Anyway, I'm very impressed with this awesome extension. Thanks!

@harshadgavali
Copy link
Owner

Hi

but I've never before encountered this swipe right for back, left for forward thing
if the gesture is set to be reversed, the animations stay the same
UI shows opposite directions when the gesture is reversed

This is intentional, this gestures are inspired by GNOME web and Chromium(on Wayland).
Gesture mimics the behaviour shown by GNOME web, Chromium and Firefox on Wayland.

Normal behaviour mimics Chromium when natual scrolling is enabled in GNOME settings for touchpad.

  • Think swipe to right as move current page to right or bring previous page to right/front
  • This is similar behaviour on touch devices (like mobile/tab browser)

Reverse gesture direction mimics Chromium when traditional scrolling is enabled.

  • Apple touch devices do not have this option at all.
  • I also can't decide on what should be good behaviour for this scenario.
  • I do not agree with current behaviour at all, but i have kept it that way because GNOME Web and Chromium have it.

I won't be able to work on this issue right away! But I'd still like to keep this issue open!

an option to turn off the animation

One of the goals on this project was to provide animation for gesture, so I'm sorry I won't add this.
If you want this you can use something like libinput gestures (wayland) or touchegg(x11) or other projects which might be able provide same functionality without conflicting with extension (I don't know whether that works or not, I haven't tried them yet).

In Firefox, setting the gesture to be reversed has no effect.

This might be bug. I wasn't able to reproduce it but please create new issue for this!

@harshadgavali harshadgavali changed the title Three-finger forward/back issues App gestures: Rethink animation for reverse gestures Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants