Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function length <50lines #5

Open
harpomaxx opened this issue Jun 11, 2020 · 2 comments
Open

Function length <50lines #5

harpomaxx opened this issue Jun 11, 2020 · 2 comments
Assignees
Labels
BiocCheck necesary for Bioconductor submission

Comments

@harpomaxx
Copy link
Owner

* Checking function lengths......................
    * NOTE: Recommended function length <= 50 lines.
      There are 6 functions > 50 lines.
      The longest 5 functions are:
        **RMST()** (R/galgo.R, line 55): 276 lines
        **galgo()** (R/galgo.R, line 887): 254 lines
        **pfun()** (R/galgo.R, line 61): 78 lines
        **offsprings()** (R/galgo.R, line 752): 71 lines
        **non_dominated_summary()** (R/results-functions.R, line 42): 67
      lines
@harpomaxx harpomaxx added the BiocCheck necesary for Bioconductor submission label Jun 11, 2020
@harpomaxx harpomaxx self-assigned this Jun 11, 2020
@martinguerrero89
Copy link
Collaborator

RMST - ready
pfun -ready (not present now)

martinguerrero89 added a commit that referenced this issue Jul 18, 2020
Resolving part of issue #5
martinguerrero89 added a commit that referenced this issue Jul 18, 2020
shorter non_dominated_summary
issue #5
@martinguerrero89
Copy link
Collaborator

Galgo main function is the only one remaining 9aa8a92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BiocCheck necesary for Bioconductor submission
Projects
None yet
Development

No branches or pull requests

2 participants