Support for single peer cluster #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables OmniPaxos to run with a single peer. What needed to be changed is to call the proper handle methods instead of directly updating the LeaderState with one's own promise and accepted index. By using the handle methods, we ensure that all required actions (e.g. updating the decided index, becoming a leader) are properly triggered. These changes were tested by running the following tests with a single node: * ble_test * consensus_test * unicache_test * flexible_quorum_test * trim_test * batching_test The other integration tests require more than 1 peer in order to test follower behavior.
|
We should add this feature when we have implemented bootstrapping, see #143 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked, before submitting a new PR.
./check.shwith no errorsIssues
Fix #143.
Changes
This commit enables OmniPaxos to run with a single peer. What needed to
be changed is to call the proper handle methods instead of directly
updating the LeaderState with one's own promise and accepted index. By
using the handle methods, we ensure that all required actions (e.g. updating
the decided index, becoming a leader) are properly triggered.
These changes were tested by running the following tests with a single node:
The other integration tests require more than 1 peer in order to test follower
behavior.