From b313d4cda41f9708593c6bf7226d99e41bf73602 Mon Sep 17 00:00:00 2001 From: Henric Trotzig Date: Wed, 24 Jun 2020 19:53:41 +0200 Subject: [PATCH 1/2] WIP: introduce error in second_page_spec I want to see if this causes failed builds or not. --- cypress/integration/second_page_spec.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cypress/integration/second_page_spec.js b/cypress/integration/second_page_spec.js index dbc3b96..aa4dee9 100644 --- a/cypress/integration/second_page_spec.js +++ b/cypress/integration/second_page_spec.js @@ -1,6 +1,8 @@ describe('A different page', () => { it('has happo tests', () => { cy.visit('/'); + + cy.get('.non-existant').should('be.visible'); cy.get('.card').happoScreenshot({ component: 'Card', variant: 'from page' }); }); }); From 3839fb842b1d2681d695b0bf184c5e10ff20d5a0 Mon Sep 17 00:00:00 2001 From: Henric Trotzig Date: Wed, 24 Jun 2020 21:17:08 +0200 Subject: [PATCH 2/2] Use `yarn` when invoking happo-cypress Hopefully this will help reproduce an issue we are seeing with silent failures. --- .circleci/config.yml | 2 +- package.json | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 95bc1b7..977503b 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -45,7 +45,7 @@ workflows: parallel: true parallelism: 2 record: true - command-prefix: "HAPPO_PROJECT=parallel HAPPO_NONCE=${CIRCLE_WORKFLOW_ID} node bin/happo-cypress.js -- yarn" + command-prefix: "HAPPO_PROJECT=parallel HAPPO_NONCE=${CIRCLE_WORKFLOW_ID} yarn happo-cypress -- -- yarn" - finalize-happo: requires: - cypress-parallel diff --git a/package.json b/package.json index c1fc4a7..ef5d80d 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,8 @@ "dev": "next --port 7654", "build": "next build", "lint": "eslint .", - "start": "next start" + "start": "next start", + "happo-cypress": "node ./bin/happo-cypress.js" }, "devDependencies": { "cypress": "^4.2.0",