You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried using the client library with frame assets hosted with CDNs skypack.dev and unpkg.com and they both have the same problem: Providing a custom query string (?svId=...) by client library results in an error or a 302 redirection.
The solution to this appears to be to use the hash (#) part of the URL instead of the search (?) part.
For that reason, I suggest that the URL parameters could be given either in the ?... part (ending at the URL end or the # character) or in the #... part.
use `#` instead of `?` to provide Query String API parameters for compatibility reasons with various HTTP server configurations, we store the parameters in the hash part of the URL - that's why they are after the # sign
Fixes: #12
POC is here: https://codesandbox.io/s/install-sv-from-a-cdn-vz6k5?file=/src/index.js
It works with Unpkg.com and Snowpack.dev CDNs, but the API change in the current PR needs some work to be done properly: changing function names, updating the docs, etc.
I tried using the client library with frame assets hosted with CDNs
skypack.dev
andunpkg.com
and they both have the same problem: Providing a custom query string (?svId=...
) by client library results in an error or a 302 redirection.The solution to this appears to be to use the hash (
#
) part of the URL instead of the search (?
) part.For that reason, I suggest that the URL parameters could be given either in the
?...
part (ending at the URL end or the#
character) or in the#...
part.Then we could rename the "Query String API" to "URL API". We could do it at once with https://github.com/handsontable/spreadsheet-viewer-dev/issues/942
The text was updated successfully, but these errors were encountered: