Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML components to MUI: ./src/pages/Home.js #1717

Open
4 tasks done
Tracked by #1617
JackHaeg opened this issue Jul 30, 2024 · 5 comments · May be fixed by #1840
Open
4 tasks done
Tracked by #1617

Update HTML components to MUI: ./src/pages/Home.js #1717

JackHaeg opened this issue Jul 30, 2024 · 5 comments · May be fixed by #1840
Assignees
Labels

Comments

@JackHaeg
Copy link
Member

JackHaeg commented Jul 30, 2024

Overview

Review all components in./src/pages/Home.js and replace all standard HTML components with applicable MUI components.

Action Items

  • Review components in:./src/pages/Home.js and search for any standard HTML components.
    • IF standard HTML components are found in the file:
      • Replace these standard HTML components with applicable MUI components.
        • Ensure select field integrates changes from the Selection Field details below
      • Make a PR for this file

Selection Field

This component contains a selection field with selection options. Please reveiw MUI's Selection Component to ensure that "Select One" is displayed by default on page load.

As it currently stands, the old select style is adding a "-- Select One --" option, this behavior doesn't need to be transferred into the new componenet.

Code Snippet
<Box className="form-input-select">
  <label htmlFor={'meeting-checkin'}>
    Select a meeting to check-in:
  </label>
  <Box className="radio-buttons">
    <select
      name={'meeting-checkin'}
      className="select-meeting-dropdown"
      onChange={handleEventChange}
      required
      defaultValue="--SELECT ONE--"
    >
      <option value="--SELECT ONE--" disabled hidden>
        --SELECT ONE--
      </option>
      {events.map((event) => {
        return (
          <option key={event._id || 0} value={event._id}>
            {event?.project?.name + ' - ' + event.name}
          </option>
        );
      })}
    </select>
  </Box>
</Box>

Resources

@github-project-automation github-project-automation bot moved this to New Issue Approval in P: VRMS: Project Board Jul 30, 2024
@JackHaeg JackHaeg changed the title ./src/pages/Home.js Update HTML components to MUI: ./src/pages/Home.js Jul 30, 2024
@JackHaeg JackHaeg moved this from New Issue Approval to Prioritized Backlog in P: VRMS: Project Board Jul 30, 2024
@JackHaeg JackHaeg added this to the Y - Excellent Level milestone Jul 30, 2024
@jng34 jng34 self-assigned this Dec 17, 2024
@JackHaeg
Copy link
Member Author

@jng34 when you assign yourself an issue, please be sure to change the status to "in progress" (I went ahead and changed the status). Also, please only assign yourself 1 issue at a time. I recommend finishing this issue first before working on #1714, which it looks like you assigned yourself to a few days ago.

Thanks!

@JackHaeg JackHaeg moved this from Prioritized Backlog to In progress in P: VRMS: Project Board Jan 14, 2025
@jng34
Copy link
Member

jng34 commented Jan 14, 2025

Oops, totally forgot. Will do, moving forward. Thank you, Jack.

@jng34 jng34 linked a pull request Jan 21, 2025 that will close this issue
@jng34 jng34 moved this from In progress to Done in P: VRMS: Project Board Jan 28, 2025
@jng34 jng34 closed this as completed by moving to Done in P: VRMS: Project Board Jan 28, 2025
@github-project-automation github-project-automation bot moved this from Done to Final QA (product) in P: VRMS: Project Board Jan 28, 2025
@JackHaeg
Copy link
Member Author

JackHaeg commented Jan 28, 2025

Hi @jng34 I see that the PR linked to this issue is still open: #1840

  • Usually, we allow for the GitHub automation to automatically close an issue once the linked PR is merged. In other words, we leave issues open (with the status "in progress") until the PR is merged. That way, if a PR is not merged and needs more work, the issue is still correctly displayed as "open."

I'll re-open this issue for now and will change the status back to "in progress" :)

@JackHaeg JackHaeg reopened this Jan 28, 2025
@github-project-automation github-project-automation bot moved this from Final QA (product) to New Issue Approval in P: VRMS: Project Board Jan 28, 2025
@JackHaeg JackHaeg moved this from New Issue Approval to In progress in P: VRMS: Project Board Jan 28, 2025
@jng34
Copy link
Member

jng34 commented Jan 28, 2025

@JackHaeg got it! Sorry, and thank you for being patient with me as I learn the ropes. Can I move onto another issue in the meantime?

@JackHaeg
Copy link
Member Author

No worries @jng34! And yes - feel free to hop on another issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants