Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change plugin's content assist contributors to support asynchronous non-blocking completions #471

Open
difflaender opened this issue Sep 8, 2023 · 2 comments

Comments

@difflaender
Copy link

difflaender commented Sep 8, 2023

Currently, installing the GWT Eclipse plugin disables non-blocking proposal computation in Eclipse because (according to the UI message) com.gwtplugins.gwt.eclipse.core.jsniCompletionProposalComputer does currently not set the flag that was introduced in Eclipse 4.14:
https://eclipse.dev/eclipse/news/4.14/jdt.php#completion-ext-flag-uithread

GwtEclipsePluginNonBlockingCompletion

It's possible that further adjustments with regards to thread safety could be needed in code.

@difflaender
Copy link
Author

For reference, these are the changes that the Groovy Eclipse plugin had to do to make its own proposal computations async:
groovy/groovy-eclipse@de5aced
groovy/groovy-eclipse@da8a60c

@protoism
Copy link
Contributor

Hi @difflaender, this ticket might be super simple, or a nightmare, depending on thread safety issues which are not very simple to analyze.
I had a quick look at https://github.com/gwt-plugins/gwt-eclipse-plugin/blob/main/plugins/com.gwtplugins.gwt.eclipse.core/src/com/google/gwt/eclipse/core/editors/java/JsniMethodBodyCompletionProposalComputer.java and... things might be safe, it all depends on how Eclipse work under the hood.
Possibly the code to retrieve image looks "suspicious" from a threading point of view.
Why don't you try to have a look at it?
It should not be that complicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants