Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to run "git push origin refs/notes/gocoverage" on pull requests from forks fails due to permissions #74

Open
lazyguru opened this issue May 27, 2024 · 0 comments · May be fixed by #75

Comments

@lazyguru
Copy link

When a pull request is opened from a public fork, the action is trying to run "git push origin refs/notes/gocoverage" which fails because GH_TOKEN cannot have write access when run from a fork on a public repo. But even still, I'm not sure it should be running anyway? From your README you state:

On merge to main, the action runs go test, generates coverage data and attaches it to a git note associated with the latest's commits' SHA.

So in the (unmerged) PR we don't need to attach a new "git note", we only need to generate the delta and report on it based on a previous "git" note" off of the base branch.

@lazyguru lazyguru linked a pull request May 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant