You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, Prout only interacts with PRs that touch folders within the project that are next to, or below, a .prout.json config file. This makes sense, because the project might contain many other folders that end up getting deployed to other destinations- that might have other checkpoints, or no checkpoint at all.
Multi-folder support?
This PR didn't touch the dashboard folder (only shared-lib/src/...), and so was correctly ignored by Prout: https://github.com/guardian/ophan/pull/1265/files - but code in shared-lib/src/...does end up deployed to the Ophan Dashboard, so it would be nice to know about it being seen at that checkpoint.
Diagnostics?
It would also be good to have an authenticated endpoint that users can look at to see how Prout regards their project (what is the status of the PRs? which folders is Prout watching?) - any user with push access to a given repo should be able to see that information. Timing attacks in establishing that?! Shouldn't be an issues so long as we are just initially validating the user has push access to the repo, and then checking that it's on Prout's whitelist.
At the moment, Prout only interacts with PRs that touch folders within the project that are next to, or below, a
.prout.json
config file. This makes sense, because the project might contain many other folders that end up getting deployed to other destinations- that might have other checkpoints, or no checkpoint at all.Multi-folder support?
This PR didn't touch the
dashboard
folder (onlyshared-lib/src/...
), and so was correctly ignored by Prout: https://github.com/guardian/ophan/pull/1265/files - but code inshared-lib/src/...
does end up deployed to the Ophan Dashboard, so it would be nice to know about it being seen at that checkpoint.Diagnostics?
It would also be good to have an authenticated endpoint that users can look at to see how Prout regards their project (what is the status of the PRs? which folders is Prout watching?) - any user with push access to a given repo should be able to see that information. Timing attacks in establishing that?! Shouldn't be an issues so long as we are just initially validating the user has push access to the repo, and then checking that it's on Prout's whitelist.
cc @philwills
The text was updated successfully, but these errors were encountered: