From d166283b405ede1bd6a4b965c2348b494eb31d70 Mon Sep 17 00:00:00 2001 From: Luwei Ge Date: Thu, 4 Apr 2024 19:57:42 +0000 Subject: [PATCH 1/3] sync the handshaker.proto --- grpc/gcp/handshaker.proto | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/grpc/gcp/handshaker.proto b/grpc/gcp/handshaker.proto index ad33eda8..8e23a246 100644 --- a/grpc/gcp/handshaker.proto +++ b/grpc/gcp/handshaker.proto @@ -125,11 +125,11 @@ message ServerHandshakeParameters { // specified. Otherwise, the handshaker chooses a default local identity. repeated Identity local_identities = 2; - // (Optional) An access token created by the caller only intended for use in - // ALTS connections. The access token that should be used to authenticate to - // the peer. The access token MUST be strongly bound to the ALTS credentials - // used to establish the connection that the token is sent over. - optional string access_token = 3; + // An identity token created by GKE MDS only intended for use in Direct Path + // connections. The identity token should be used to authenticate to the peer. + // It MUST be strongly bound to the ALTS credentials used to establish the + // connection that the token is sent over. + optional string token = 3; } message StartServerHandshakeReq { From f33ef3f18f9f1ef44ddc2c5a9374061022f141e1 Mon Sep 17 00:00:00 2001 From: Luwei Ge Date: Thu, 4 Apr 2024 20:33:57 +0000 Subject: [PATCH 2/3] address comment --- grpc/gcp/handshaker.proto | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/grpc/gcp/handshaker.proto b/grpc/gcp/handshaker.proto index 8e23a246..ff2c9a33 100644 --- a/grpc/gcp/handshaker.proto +++ b/grpc/gcp/handshaker.proto @@ -125,10 +125,10 @@ message ServerHandshakeParameters { // specified. Otherwise, the handshaker chooses a default local identity. repeated Identity local_identities = 2; - // An identity token created by GKE MDS only intended for use in Direct Path - // connections. The identity token should be used to authenticate to the peer. - // It MUST be strongly bound to the ALTS credentials used to establish the - // connection that the token is sent over. + // An token created by the caller only intended for use in + // ALTS connections. The token should be used to authenticate to + // the peer. The token MUST be strongly bound to the ALTS credentials + // used to establish the connection that the token is sent over. optional string token = 3; } From aa61e9cd7801686e4d997527f2a50e7a590fe36c Mon Sep 17 00:00:00 2001 From: Luwei Ge Date: Thu, 4 Apr 2024 21:26:05 +0000 Subject: [PATCH 3/3] fix typo --- grpc/gcp/handshaker.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grpc/gcp/handshaker.proto b/grpc/gcp/handshaker.proto index ff2c9a33..2f546233 100644 --- a/grpc/gcp/handshaker.proto +++ b/grpc/gcp/handshaker.proto @@ -125,7 +125,7 @@ message ServerHandshakeParameters { // specified. Otherwise, the handshaker chooses a default local identity. repeated Identity local_identities = 2; - // An token created by the caller only intended for use in + // A token created by the caller only intended for use in // ALTS connections. The token should be used to authenticate to // the peer. The token MUST be strongly bound to the ALTS credentials // used to establish the connection that the token is sent over.