Problem with fetching not a json features

[melniqw]

We have faced a problem in the lib code caused by the marked string. If the features receive not a json string (for some reason) we fallback to crash right after initialization.

[Bohdan-Kim]

Not a json features but what the features?
My feature type was String and it was fetched successfully

[melniqw]

Yeah I just figured out one more thing, it gets crashed even if we got 500.
Because onSuccess is still being called after error, so check does not stop the block actually.

And the features request was a second step of getting malformed answer.

About the features response: still there is a possibility to get something unexpected even with 200 code, so handling the possibility of bad json when decoding is still a good practice imo

[Bohdan-Kim]

It should be checked.
Do you have ability to use NetworkDispatcher based on Ktor instead of OkHttp?

[melniqw]

I came to a solution to write my custom NetworkDispatcher with the fixes in consumeGETRequest and consumePOSTRequest methods:

[Bohdan-Kim]

Great!

[Bohdan-Kim]

Yeah I just figured out one more thing, it gets crashed even if we got 500. Because onSuccess is still being called after error, so check does not stop the block actually. And the features request was a second step of getting malformed answer.

About the features response: still there is a possibility to get something unexpected even with 200 code, so handling the possibility of bad json when decoding is still a good practice imo

It is screenshot from OkHttpDispatcher v1.0.0; v1.0.2 is available on MavenCentral

[vazarkevych]

Hi, @melniqw. Have you tried increasing the version? If that resolves the issue, please close the it.