Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce max_attempts default value #1439

Open
1 task done
shhlife opened this issue Dec 12, 2024 · 4 comments
Open
1 task done

Reduce max_attempts default value #1439

shhlife opened this issue Dec 12, 2024 · 4 comments
Labels
type:enhancement Improvements to existing features
Milestone

Comments

@shhlife
Copy link

shhlife commented Dec 12, 2024

Currently max_attempts is set to 10, which can make it appear that the framework is hung when it's really just trying something a number of times.

Would like to discuss reducing the default number to 2 or 3. Usually if something is going to fail, one or two retries is fine - and if the user needs more they can always increase it.

@shhlife shhlife added the type:enhancement Improvements to existing features label Dec 12, 2024
@collindutter collindutter added this to the 2.0 milestone Dec 19, 2024
@collindutter collindutter added the type: discussion Open for conversation or brainstorming label Dec 19, 2024
@collindutter collindutter removed the type: discussion Open for conversation or brainstorming label Jan 7, 2025
@collindutter
Copy link
Member

I wonder if we should retry at all? Should it be opt-in?

@shhlife
Copy link
Author

shhlife commented Jan 8, 2025

good point, maybe not? Usually things fail due to something that retrying wouldn't resolve.. like an invalid api key.

@collindutter
Copy link
Member

Or maybe we just need to refine the ignored exception types.

@shhlife
Copy link
Author

shhlife commented Jan 8, 2025

yeah, that would help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Improvements to existing features
Projects
None yet
Development

No branches or pull requests

2 participants