Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatroom with the same name should be allowed to be created #37

Open
gridhead opened this issue Oct 16, 2020 · 9 comments
Open

Chatroom with the same name should be allowed to be created #37

gridhead opened this issue Oct 16, 2020 · 9 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@gridhead
Copy link
Owner

Check with the server and disallow chatroom creation if a chatroom with the same name already exists.

@gridhead gridhead added bug Something isn't working help wanted Extra attention is needed hacktoberfest Contribute to the notion of open-source this October! labels Oct 16, 2020
@vinmay
Copy link
Contributor

vinmay commented Oct 16, 2020

Hey @t0xic0der, I see the issue says 'Chatroom with the same name should be allowed to be created' but ion the comment I see we want to disallow creation if we find chatrooms with same name. Is this a typo?

@adhyay2000
Copy link

Can I work on this?

@gridhead
Copy link
Owner Author

Hey @t0xic0der, I see the issue says 'Chatroom with the same name should be allowed to be created' but ion the comment I see we want to disallow creation if we find chatrooms with same name. Is this a typo?

Two chatrooms with the same name lose their uniqueness so if a chatroom with a name exists, another chatroom with the same name should not be allowed to be created. Do you want this issue to be assigned to you?

@gridhead
Copy link
Owner Author

You have been assigned 2 issues from this repository as of now @adhyay2000 and @vinmay has been assigned 1 issue. I would suggest completing them first before moving onto this one.

@Luv8436
Copy link

Luv8436 commented Oct 17, 2020

Hii @t0xic0der please assign this issue to me. I am intersted in working this.

@gridhead
Copy link
Owner Author

Cool. I am assigning this issue to you. @Luv8436

Feel free to leave a star at the repository if you find it useful.

@gridhead
Copy link
Owner Author

@Luv8436 did you make any progress on this?

Should @Luv8436 not respond or expresses disinterest, anyone up for it? @nat236919 @vivek-blip

@thevivekmnair
Copy link
Contributor

@Luv8436 did you make any progress on this?

Should @Luv8436 not respond or expresses disinterest, anyone up for it? @nat236919 @vivek-blip

Yes i'm interested in solving this issue

@adhyay2000
Copy link

Hi @vivek-blip, you can see the PR opened by me. It already contains the code for generating the chatroom name at server side, you can maintain a set there to ensure just unique names are generated. It will solve the issue i guess. What do you say?

@gridhead gridhead removed the hacktoberfest Contribute to the notion of open-source this October! label Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants