-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chatroom with the same name should be allowed to be created #37
Comments
Hey @t0xic0der, I see the issue says 'Chatroom with the same name should be allowed to be created' but ion the comment I see we want to disallow creation if we find chatrooms with same name. Is this a typo? |
Can I work on this? |
Two chatrooms with the same name lose their uniqueness so if a chatroom with a name exists, another chatroom with the same name should not be allowed to be created. Do you want this issue to be assigned to you? |
You have been assigned 2 issues from this repository as of now @adhyay2000 and @vinmay has been assigned 1 issue. I would suggest completing them first before moving onto this one. |
Hii @t0xic0der please assign this issue to me. I am intersted in working this. |
Cool. I am assigning this issue to you. @Luv8436 Feel free to leave a star at the repository if you find it useful. |
@Luv8436 did you make any progress on this? Should @Luv8436 not respond or expresses disinterest, anyone up for it? @nat236919 @vivek-blip |
Yes i'm interested in solving this issue |
Hi @vivek-blip, you can see the PR opened by me. It already contains the code for generating the chatroom name at server side, you can maintain a set there to ensure just unique names are generated. It will solve the issue i guess. What do you say? |
Check with the server and disallow chatroom creation if a chatroom with the same name already exists.
The text was updated successfully, but these errors were encountered: