Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ Refactor: maximize use of Quasar components #82

Open
dlqqq opened this issue Nov 1, 2020 · 1 comment
Open

🛠️ Refactor: maximize use of Quasar components #82

dlqqq opened this issue Nov 1, 2020 · 1 comment
Labels
Domain: Dev Experience This issue pertains to a developer's emotions and attitudes when building Grey Software. Role: Software Engineer Uses technology to design, develop, test, and maintain creative software solutions.

Comments

@dlqqq
Copy link
Contributor

dlqqq commented Nov 1, 2020

Motivation 🏁

I'm currently in the process of re-factoring the practice card, and there are a few glaring issues with the existing codebase, especially with the Vue SFCs. We should begin with the home page. Observe that the root element is the q-page component. This is wrong and leads to unexpected layout behavior. From the Quasar Docs:

A QPage must be encapsulated by QPageContainer, which in turn must be a child of QLayout.

The QLayout element provides built-in components that make generating user layouts far less error prone and more well-documented. There is no need to write use div elements with the mobile-container or config-header CSS classes, when Quasar ships with dedicated components for containers and headers.

Many more similar issues exist throughout the codebase, which all share a pattern of wrapping everything in a div and writing a custom CSS class. This is really hard to read, debug, or maintain.

Describe your refactoring solution 🛠️

The main goal is to re-factor the code using Quasar elements without changing the UI at all.

Additional details ℹ️

I'm unsure of how to make my PRs. Do I just submit one massive PR that re-factors a ton of source files? Suggestions welcome.

@dlqqq dlqqq added Domain: Dev Experience This issue pertains to a developer's emotions and attitudes when building Grey Software. Role: Software Engineer Uses technology to design, develop, test, and maintain creative software solutions. labels Nov 1, 2020
@ArsalaBangash
Copy link
Member

@diracs-delta You can submit one PR with all these refactors :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Dev Experience This issue pertains to a developer's emotions and attitudes when building Grey Software. Role: Software Engineer Uses technology to design, develop, test, and maintain creative software solutions.
Projects
None yet
Development

No branches or pull requests

2 participants