Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data race in lib/srv/regular tests #4781

Closed
awly opened this issue Nov 10, 2020 · 1 comment · Fixed by #4790
Closed

Data race in lib/srv/regular tests #4781

awly opened this issue Nov 10, 2020 · 1 comment · Fixed by #4790
Assignees
Labels
automated-testing-problem Problems with automated tests (unit tests, integration tests) good-starter-issue Good starter issue to start contributing to Teleport

Comments

@awly
Copy link
Contributor

awly commented Nov 10, 2020

==================
WARNING: DATA RACE
Read at 0x00c000c140a0 by goroutine 306:
  github.com/gravitational/teleport/lib/utils.UTC()
      /home/awly/src/teleport/lib/utils/time.go:40 +0x4e
  github.com/gravitational/teleport/lib/services.(*Metadata).CheckAndSetDefaults()
      /home/awly/src/teleport/lib/services/resource.go:728 +0x2ac
  github.com/gravitational/teleport/lib/services.(*ServerV2).CheckAndSetDefaults()
      /home/awly/src/teleport/lib/services/server.go:347 +0x5b
  github.com/gravitational/teleport/lib/services.(*TeleportServerMarshaler).MarshalServer()
      /home/awly/src/teleport/lib/services/server.go:873 +0x5e
  github.com/gravitational/teleport/lib/reversetunnel.marshalDiscoveryRequest()
      /home/awly/src/teleport/lib/reversetunnel/discovery.go:64 +0x114
  github.com/gravitational/teleport/lib/reversetunnel.(*remoteConn).sendDiscoveryRequest()
      /home/awly/src/teleport/lib/reversetunnel/conn.go:238 +0xb7
  github.com/gravitational/teleport/lib/reversetunnel.(*localSite).handleHeartbeat()
      /home/awly/src/teleport/lib/reversetunnel/localsite.go:372 +0x101b

Previous write at 0x00c000c140a0 by goroutine 316:
  github.com/gravitational/teleport/lib/utils.UTC()
      /home/awly/src/teleport/lib/utils/time.go:45 +0x15a
  github.com/gravitational/teleport/lib/services.(*Metadata).CheckAndSetDefaults()
      /home/awly/src/teleport/lib/services/resource.go:728 +0x2ac
  github.com/gravitational/teleport/lib/services.(*ServerV2).CheckAndSetDefaults()
      /home/awly/src/teleport/lib/services/server.go:347 +0x5b
  github.com/gravitational/teleport/lib/services.(*TeleportServerMarshaler).MarshalServer()
      /home/awly/src/teleport/lib/services/server.go:873 +0x5e
  github.com/gravitational/teleport/lib/reversetunnel.marshalDiscoveryRequest()
      /home/awly/src/teleport/lib/reversetunnel/discovery.go:64 +0x114
  github.com/gravitational/teleport/lib/reversetunnel.(*remoteConn).sendDiscoveryRequest()
      /home/awly/src/teleport/lib/reversetunnel/conn.go:238 +0xb7
  github.com/gravitational/teleport/lib/reversetunnel.(*localSite).handleHeartbeat()
      /home/awly/src/teleport/lib/reversetunnel/localsite.go:372 +0x101b

Goroutine 306 (running) created at:
  github.com/gravitational/teleport/lib/reversetunnel.(*server).handleNewService()
      /home/awly/src/teleport/lib/reversetunnel/srv.go:652 +0x352
  github.com/gravitational/teleport/lib/reversetunnel.(*server).handleHeartbeat()
      /home/awly/src/teleport/lib/reversetunnel/srv.go:620 +0x637
  github.com/gravitational/teleport/lib/reversetunnel.(*server).HandleNewChan()
      /home/awly/src/teleport/lib/reversetunnel/srv.go:557 +0x43c

Goroutine 316 (running) created at:
  github.com/gravitational/teleport/lib/reversetunnel.(*server).handleNewService()
      /home/awly/src/teleport/lib/reversetunnel/srv.go:652 +0x352
  github.com/gravitational/teleport/lib/reversetunnel.(*server).handleHeartbeat()
      /home/awly/src/teleport/lib/reversetunnel/srv.go:620 +0x637
  github.com/gravitational/teleport/lib/reversetunnel.(*server).HandleNewChan()
      /home/awly/src/teleport/lib/reversetunnel/srv.go:557 +0x43c
==================
OK: 24 passed, 1 skipped
--- FAIL: TestRegular (63.28s)
    testing.go:1023: race detected during execution of test
@awly awly added good-starter-issue Good starter issue to start contributing to Teleport automated-testing-problem Problems with automated tests (unit tests, integration tests) labels Nov 10, 2020
@awly awly changed the title Data race in lib/srv/regular tests Data race in lib/reversetunnel tests Nov 16, 2020
@awly awly changed the title Data race in lib/reversetunnel tests Data race in lib/srv/regular tests Nov 16, 2020
@a-palchikov
Copy link
Contributor

Closed in #4790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-testing-problem Problems with automated tests (unit tests, integration tests) good-starter-issue Good starter issue to start contributing to Teleport
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants