Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video file names are altered during upload #21

Open
firecat53 opened this issue Jan 18, 2021 · 4 comments · May be fixed by #27
Open

Video file names are altered during upload #21

firecat53 opened this issue Jan 18, 2021 · 4 comments · May be fixed by #27

Comments

@firecat53
Copy link

firecat53 commented Jan 18, 2021 •
edited
Loading

For example, I used smugcli to upload 20200703_200206.mp4 and after upload the filename shown on the website is 20200703_200206_mp4.MP4. This causes both smugcli sync and uploads from the website to upload the video again because the filename doesn't match.

Thanks!

(sorry to spam you with several issues in a row! Useful project!)
@durin42
Copy link
Contributor

durin42 commented Jul 24, 2021

I've spent some time poking at this today, and there's two rename patterns I've seen, with no seeming reason triggering the rename. Given a file named FOO.EXT (where EXT in my case is always either mp4 or MP4), I've seen the following:

FOO_EXT.MP4
FOO.MP4

A related-but-different problem is that sometimes uploaded videos (all uploaded by smugcli!) are missing ImageMetadata.DateTimeModified keys, which was triggering datetime.datetime.strptime failures.

I'm working on patches for both.

@durin42
Copy link
Contributor

durin42 commented Jul 24, 2021

FWIW I've never seen this on .MOV or .mov files, but I have those.

durin42 added a commit to durin42/smugcli that referenced this issue Jul 24, 2021
@durin42
get_children: allow method to work on non-container items
10eb269 
This unblocks removing movies with `smugcli rm`, which helped me while
I was debugging duplicated movies resulting from graveljp#21.
durin42 added a commit to durin42/smugcli that referenced this issue Jul 24, 2021
@durin42
smugmug_fs: handle SmugMug shenanigans that sometimes movie files
8b076aa 
Experimentally FOO.mp4 can get renamed either to FOO_mp4.MP4 or
FOO.MP4. It's unclear what triggers this behavior (presumably
something about the video content, maybe something that triggers a
re-encode or re-mux), but this avoids duplicating the video on every
`smugcli sync` invocation for files that get renamed like this.

Fixes graveljp#21. (As far as I can tell.)
This was referenced Jul 24, 2021
Merged
Open
@firecat53
Copy link
Author

Cool! I'll hopefully have a chance to test your fix here shortly.

graveljp pushed a commit that referenced this issue Nov 2, 2022
@durin42 @graveljp
get_children: allow method to work on non-container items
4297ef5 
This unblocks removing movies with `smugcli rm`, which helped me while
I was debugging duplicated movies resulting from #21.
@firecat53
Copy link
Author

Moved off of Smugmug. Will leave this open in case others are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

smugmug_fs: handle SmugMug shenanigans that sometimes movie files durin42/smugcli
2 participants
@durin42 @firecat53