Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @oneOf support to introspection query #4078

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Add @oneOf support to introspection query #4078

merged 3 commits into from
Jun 21, 2024

Conversation

maciesielka
Copy link
Contributor

Fixes #4077

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 2, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify Netlify
Copy link

netlify bot commented May 2, 2024 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 633331a
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/664ff76a3cac4000089737f5
😎 Deploy Preview https://deploy-preview-4078--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maciesielka maciesielka force-pushed the maciesielka/add-one-of-support-to-introspection branch from c2c95c1 to 9bae8e8 Compare May 2, 2024 16:54
@maciesielka maciesielka marked this pull request as ready for review May 2, 2024 16:57
@maciesielka maciesielka mentioned this pull request May 2, 2024
Closed
@maciesielka
Copy link
Contributor Author

👋🏻 @graphql/graphql-js-reviewers, just a friendly bump per the Contribution Guidelines. Excited to address any feedback y'all have.

mmgoodnow
mmgoodnow reviewed May 23, 2024
View reviewed changes
src/utilities/getIntrospectionQuery.ts Outdated Show resolved Hide resolved
src/utilities/getIntrospectionQuery.ts Outdated Show resolved Hide resolved
@maciesielka maciesielka requested a review from mmgoodnow May 24, 2024 02:13
@JoviDeCroock JoviDeCroock mentioned this pull request Jun 12, 2024
Closed
3 tasks
@maciesielka
Copy link
Contributor Author

@JoviDeCroock, @mmgoodnow appreciate your reviews and hopefully I've addressed your feedback. Any idea what it takes to get something like this merged?

benjie
benjie approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this vital feature!

@benjie benjie added the PR: feature 🚀 requires increase of "minor" version number label Jun 21, 2024
@benjie benjie merged commit 7df786e into graphql:main Jun 21, 2024
20 checks passed
benjie pushed a commit that referenced this pull request Jun 21, 2024
@maciesielka @benjie
Add @oneOf support to introspection query (#4078)
5fd46be
@benjie benjie mentioned this pull request Jun 21, 2024
Merged
@jasonkuhrt jasonkuhrt mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@benjie benjie benjie approved these changes

@mmgoodnow mmgoodnow Awaiting requested review from mmgoodnow

Assignees
No one assigned
Labels
PR: feature 🚀 requires increase of "minor" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introspection queries don't support @oneOf
4 participants
@maciesielka @benjie @mmgoodnow @JoviDeCroock