Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BlockInfo] Increase the amount of blocks and biomes that can be registered. #75

Open
granny opened this issue Dec 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@granny
Copy link
Owner

granny commented Dec 12, 2024

Currently there is a limit of 1023 registered blocks and 1023 registered biomes. Find a way to increase that limit for blocks (Mojang currently has up to 1096 blocks and 65 biomes).

Three ways this could go:

  1. Just go ahead and lower the limit for biomes and increase the limit for blocks.
  2. Change the packed integer into a packed long.
  3. Dynamically adjust the limit for blocks and biomes, with priority for blocks.

All three possible solutions would require making changes to the pl3xmap file protocol, which means changing how it functions in the webmap. An announcement in the discord will need to be made to let users know of this change for those who have read-only set to true in their config.

@granny granny added the enhancement New feature or request label Dec 12, 2024
@granny
Copy link
Owner Author

granny commented Dec 25, 2024

Pushed 56cfdb3 which gives the block limit some breathing room. Limit for blocks is now 2047, and the limit for biomes is 511. An announcement was made in the discord server.

This "solves" the issue temporarily while I continue to think about the best long-term solution to properly solve this issue.

Server admins using Pl3xMap for Fabric will see the limit being reached in modpacks with a huge number of biomes or mods that increase the number of blocks in Minecraft exponentially, such as the Chipped mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant