Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove "ignore" from webhooks adapter config #696

Open
Tracked by #675
KnorpelSenf opened this issue Dec 15, 2024 · 0 comments
Open
Tracked by #675

feat: remove "ignore" from webhooks adapter config #696

KnorpelSenf opened this issue Dec 15, 2024 · 0 comments

Comments

@KnorpelSenf
Copy link
Member

All use cases of this option lead to incorrect bot code. There is no reason to ever use this option, so why have it?

The old behaviour can be retained by not awaiting next in middleware. Just in case somebody wants to stick with their existing broken code.
@KnorpelSenf KnorpelSenf mentioned this issue Dec 15, 2024
Open
51 tasks
@shevernitskiy shevernitskiy mentioned this issue Jan 16, 2025
Merged
@KnorpelSenf KnorpelSenf changed the title feat: rename or remove "return" from webhooks adapter config feat: remove "return" from webhooks adapter config Jan 20, 2025
@KnorpelSenf KnorpelSenf changed the title feat: remove "return" from webhooks adapter config feat: remove "ignore" from webhooks adapter config Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KnorpelSenf